KronicDeth / intellij-elixir

Elixir plugin for JetBrain's IntelliJ Platform (including Rubymine)
Other
1.83k stars 153 forks source link

Huge icons are everywhere #1264

Closed ignatov closed 5 years ago

ignatov commented 6 years ago

image

ignatov commented 6 years ago

And the same in the SDK dialog image

ignatov commented 6 years ago

And this is not the end image

ignatov commented 6 years ago

And... image

ignatov commented 6 years ago

This is an endless joke image

ignatov commented 6 years ago

image

KronicDeth commented 6 years ago

@ignatov

  1. Which IDE?
  2. Which version of the IDE?
  3. Which OS
  4. Is the display in a HiDPI resoluton?

They look normal in IntelliJ 2018.2.2 on macOS at 2048x1280.

screen shot 2018-09-19 at 5 03 37 am

I'm guessing it is grabbing the @2x or @3x versions of the icons (like in https://github.com/KronicDeth/intellij-elixir/tree/e912c44b4ae04c91f9709f4cee763e6f637b10ac/resources/icons/project). I just followed the rules I could find in JetBrains docs for making those. Do you know anyone at @JetBrains that understands the @2x and @3x system for the icons and can check my work? Do I not need to make @2x and @3x versions when I use SVGs?

ignatov commented 6 years ago

Idea 2018.3 EAP on macOS.

theevangelista commented 6 years ago

Same thing on Windows 10 with IntelliJ 2018.3 EAP On HiDPI (2560x1440)

theevangelista commented 6 years ago

I think this EAP increases the size of menu itens and maybe the plugin is using a 2x the size to counter it since there is no available size.

KronicDeth commented 6 years ago

Does it happen with the non-EAP?

On Thu, Sep 20, 2018 at 4:05 PM João Pedro de Carvalho < notifications@github.com> wrote:

Same thing on Windows 10 with 2018.3 EAP

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KronicDeth/intellij-elixir/issues/1264#issuecomment-423315118, or mute the thread https://github.com/notifications/unsubscribe-auth/AASNEwBt1kqzrjC0uyFS52FTxoNaOcr2ks5uc_UJgaJpZM4Wu4E6 .

theevangelista commented 6 years ago

Does not happen on 2018.2.4

KronicDeth commented 6 years ago

I opened https://youtrack.jetbrains.com/issue/IDEA-199289 in case this is a bug in the EAP or just some change made to the Icon system that I need to adjust for to bbe 2018.3 compatible.

KronicDeth commented 5 years ago

@ignatov is this still a problem for you? I don't see it in the latest EAP:

screen shot 2018-10-15 at 9 27 24 am

KronicDeth commented 5 years ago

Oh, it is a HiDPI/Retina only thing. Had my laptop hooked up to a projector and it kicked the laptop display to a native resolution and now I see the bug!

screen shot 2018-10-15 at 6 28 53 pm screen shot 2018-10-15 at 6 29 06 pm
seanwash commented 5 years ago

I know this is an old issue, but I've been noticing just one large icon when viewing .exs files, both retina and non. image

IntelliJ IDEA 2019.1.2 (Ultimate Edition) Build #IU-191.7141.44, built on May 7, 2019 JRE: 1.8.0_202-release-1483-b49 x86_64 JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o macOS 10.14.5

Intellij-elixir v10.5.0