KronicDeth / intellij-elixir

Elixir plugin for JetBrain's IntelliJ Platform (including Rubymine)
Other
1.82k stars 153 forks source link

Version not compatible with IntelliJ 2023.3.x #3481

Open adrian-goe opened 8 months ago

adrian-goe commented 8 months ago

Hi, could you update the build to be compatible with the latest IntelliJ version? Thanks 🙏🏻

Screenshot 2023-12-13 at 14 01 10 Screenshot 2023-12-13 at 14 00 40

mengelseatz commented 8 months ago

It looks like there was already code committed/merged for this? I don't know what the process is to get this into JetBrains though

https://github.com/KronicDeth/intellij-elixir/commit/876b7702e439c398f4ae2cc41647eb45d2a157ea

adrian-goe commented 8 months ago

@mengelseatz yes, it seems to be available in the latest canary version. If that is stable enough, release it 😄

But as a side note, I noticed something: According to the canary changelogs for version 16.0.1, its available in version 16.0.0. Screenshot 2023-12-17 at 14 50 15

According to latest stable build build on the plugin page, it says only support Intelij 2023.2 Screenshot 2023-12-17 at 14 50 54

mengelseatz commented 8 months ago

Weird.. clearly it's not working in 16.0.0 though 😄. I guess we need to wait for a build at this point. I'm not familiar with the build cycle for this project as I just got back into Elixir a few weeks ago after a multi-year hiatus. Luckily Emacs works well enough for me to continue working.

MontiniCristian commented 8 months ago

@mengelseatz you can download the latest tag (pre-release) as a zip file and manually install it, it works smoothly on my machine with RubyMine 2023.3.1:

Screenshot from 2023-12-19 09-01-28

mengelseatz commented 8 months ago

Thanks @MontiniCristian !

Cervajz commented 8 months ago

I think it was not released because the tests failed on the latest merge:

https://github.com/KronicDeth/intellij-elixir/actions/runs/7147009230

KronicDeth commented 8 months ago

Yep, the tests failed, so I need to go in and fix the compatibility problems

piacsek commented 8 months ago

Yep, the tests failed, so I need to go in and fix the compatibility problems

Hi @KronicDeth! I really like Elixir, Idea and this plugin. I'd like to start contributing here. I see there many open issues, could you point me a good one to get started?

Thanks for putting so much time and effort into this plugin, BTW!

piacsek commented 8 months ago

@MontiniCristian It didn't work for me :/ Getting the same error for all 16.X.X versions

image

Cervajz commented 8 months ago

@piacsek Did you download the correct file from the Canary channel? The name should be _intellij-elixir-16.0.1-pre20231208222626.zip, your screenshot shows 16.0.0

https://plugins.jetbrains.com/plugin/7522-elixir/versions/canary

derekcroft commented 8 months ago

@MontiniCristian I downloaded the file you mentioned and got the same message as @piacsek except with the newer version:

Screenshot 2024-01-05 at 5 37 56 PM

I uninstalled the previous version of the plugin and restarted the IDE, but no luck.

amarchen commented 7 months ago

Seems to be working now in 2023.3.3. Well, debugging still fails with "Connection attempt from node... since it cannot handle [~c"V4_NC", ~c"UNLINK_ID"]", but that's another issue - https://github.com/KronicDeth/intellij-elixir/issues/3362