Simplify type system - Githubissues

Kronuz / pyScss

pyScss, a Scss compiler for Python

MIT License

582 stars 141 forks source link

Simplify type system #138

Closed eevee closed 11 years ago

eevee commented 11 years ago

There's a whole lot of type-checking going on at the moment, which makes it difficult to follow any of the code. I'd like to cut this down a lot.

Not exhaustive:

[x] An expression AST should never contain an unwrapped basestring.
[x] undefined should be a type, and the corresponding regex should go away.

Probably wants test coverage first.

May have backwards-compatibility implications? Hard to tell!

eevee commented 11 years ago

I've done a ton of work on this; in particular the AST no longer ever contains basestring, there's only one string type, Null is a type, many of the operations have been fixed to match Ruby, and the constructors are becoming gradually more predictable.

Might as well finish what I'm doing before 1.2.

eevee commented 11 years ago

Gonna call this done and file some followup tickets if anything else comes to mind.