search

Kronuz / pyScss

pyScss, a Scss compiler for Python
MIT License
582 stars 141 forks source link

Allow disabling speedups #295

Closed jstasiak closed 10 years ago

jstasiak commented 10 years ago

It's very useful to disable speedups on demand, especially when speedup version seems less reliable than the native one (see https://github.com/Kronuz/pyScss/pull/294).

eevee commented 10 years ago

If it's all the same, I'd rather not add this complication — anywhere speedups don't match native is a serious bug. (And there's no reason we might not have the opposite problem, where speedups are right and native is wrong.)

The specific problem you had was a silly oversight on my part. The speedups were using unsigned char to iterate over each character, but anything outside latin-1 won't fit and gets truncated. It happened to be fine for curly quotes, but BULLET is U+2022, and the first byte of that is 0x22, which is ". So the speedups though there was an unterminated quote and broke down (which is #283).

Fixed in master now.

jstasiak commented 10 years ago

Yeah. that's fair. We used it as a temporary workaround for the issue. I'm happy to hear it's fixed, is there a chance for PyPI release in near future?

eevee commented 10 years ago

I'm hoping so; need to update docs, make sure I haven't broken anything for either me or @kronuz, and maybe add a way to configure without monkeypatching.