Increases parity of str-slice with Sass str-slice

Kronuz / pyScss

pyScss, a Scss compiler for Python

MIT License

582 stars 140 forks source link

Increases parity of str-slice with Sass str-slice #346

Closed william-index closed 9 years ago

william-index commented 9 years ago

relates to issue #338 When using str-slice the compiler should correct for out of bounds or index zero, like ruby Sass. This is also essential for use with the Bourbon library as of 4.2.3 and its implementation of is-length, which is handled perfectly fine by Ruby Sass.

Kronuz commented 9 years ago

Could you please add a test so we can make sure this never happens again?

william-index commented 9 years ago

@Kronuz How about now?

eevee commented 9 years ago

looks right to me, cheers!