Make C extension optional

Kronuz / pyScss

pyScss, a Scss compiler for Python

MIT License

582 stars 140 forks source link

Make C extension optional #394

Closed e0ne closed 4 years ago

e0ne commented 4 years ago

C extension is just a speedup, so we don't need to fail the installation if the build is failed.

It's a follow-up fix for 6ec33af0d01fe73d5ce2c48a9d784fb47596d641.

Closes: #393

coveralls commented 4 years ago

Coverage remained the same at 66.809% when pulling 90022c76d3456f2166c133676665c9bf1c7c1421 on e0ne:optional-build into 4f97acd2498de985f45e3127c985eafd71d34534 on Kronuz:master.

Kronuz commented 4 years ago

Make sure to make it so by default it used the C extension. Better add a “without” option.

e0ne commented 4 years ago

@Kronuz the behaviour is not changed. I just fixed the setup procedure to not fail if C extension could not be built. If libpcre is installed, pyScss will use it and C extension will work

amotoki commented 4 years ago

Looks good. I tested the PR on Ubuntu 18.04 with and without libpcre3-dev and both work well.

e0ne commented 4 years ago

@Kronuz could you please confirm that the proposed approach is good for you?

Kronuz commented 4 years ago

LGTM

e0ne commented 4 years ago

@Kronuz thanks, Germán! It seems to be good to have this merged and release 1.3.7