Linux .so only exports needed symbols

KrossX / Pokopom

Input Plugin for Emulators

MIT License

41 stars 7 forks source link

Linux .so only exports needed symbols #21

Closed Algebro7 closed 7 years ago

Algebro7 commented 7 years ago

Set the default visibility in cmake to hidden, and added an attribute to the DllExport macro to mark those functions as visible. This may be a bug or it may be normal, but for some reason the following symbols are also exported:

KrossX commented 7 years ago

I remember trying to hide symbols but eventually gave up as I couldn't get the same result as the windows dll.

Algebro7 commented 7 years ago

I agree, it seems to be the default behavior on Linux to export everything. I am fine with rejecting this PR since it seems like kind of a hack and may not be reliable, as long as you don't think exporting all symbols will cause issues.

KrossX commented 7 years ago

I like hacks! I doubt it would cause issues.