search

KrossX / Pokopom

Input Plugin for Emulators
MIT License
41 stars 7 forks source link

Fixed exports issue with Windows DLL #22

Closed Algebro7 closed 7 years ago

Algebro7 commented 7 years ago

After some Windows testing, I found that the last commit would compile on Windows, but did not export functions correctly, and the plugin would not load successfully in PCSX2. I've updated CMakeLists.txt and the current configuration now builds and loads succesfully on PCSX2 in Windows.

KrossX commented 7 years ago

Why the change from padPokopom to Pokopom?

Algebro7 commented 7 years ago

I thought for some reason the VS solution provided in the repo was building the DLL as Pokopom.dll rather than padPokopom.dll, so I renamed it to be consistent. I just looked at the file again though and I think I was wrong, so I've reverted this change in the latest commit.

KrossX commented 7 years ago

Well, the project is indeed called Pokopom but the output file is set to padPokopom. Would it be too troublesome for cmake to have different project and output names?

Algebro7 commented 7 years ago

Not at all, just tested with commit a10af9b and it works fine:

image