Krozark
commented
9 years ago First of All, have you see that there is no release version for the moment? there is maybe a reason for that.
And is a valid keyword : http://en.cppreference.com/w/cpp/keyword/and leading underscore : I've delete them (except if I've forget something) Please .... look at the sf::Event implementation before saying that memcopy is not a valid way to copy it (explained in my book)
Commented code will be removed (in the next day), and the code will be cleaned to to have the same coding convention everywhere.
Your git submodule idea completely failed, the idea is to not include the source directly in your own code base. And yea, copying entire libs like SFGUI is not the way to handle dependencies
I know that, but it's simpler for beginner because they don't have to download them one by one. In my book, I explain how to install (properly) all the dependencies. By the way it allow user to use the download from zip button, without having to do
git clone --recursive ...I haven't stole the ship, I've find it under creative common 0, so .... where is the trouble? I've forget to add a link to the original creator of some assert, and some of theme are may by a friend of me for this book, so please, stop saying that I've stole everything.
Are you trying to write proper, clean C++ (which is what SFML aims at), and teachable code or just trying to get a book with your name on the cover? Writing bad C++ code and publishing it is a way to get your book on the do not read list.
First, I haven't say "I will write a book to have my name on it" NO. The publisher contact me, and offer me this opportunity. Secondly, I wrote some proper C++ code, with sometime some C like code for optimization (explained in the book again).
Finally, what is wrong with you? If you don't like this project, just skip it, that's it. I usually appreciate feedbacks but your isn't constructive at all.
zsbzsb
Do you even test your code or care about coding standards?
'and' does not compile in C++
ok, I stand corrected on the 'and' keyword. But for reference, it doesn't work in some compilers without including the header and 99.99% of C++ code doesn't use that.
leading double underscores is forbidden in C++ (reserved by compiler implementations)
why do you have commented code all over the place?
for all words this is beyond belief, you copy a C++ union with memcpy! memcpy is meant for raw bytes, not for defined classes/unions/structs that have clearly defined copy ctors. not to mention the fact of how ironic it is because you do it from your own copy ctor. not to mention the fact that the memory may not be contigues.
http://stackoverflow.com/a/12135856
Your git submodule idea completely failed, the idea is to not include the source directly in your own code base. And yea, copying entire libs like SFGUI is not the way to handle dependencies.
This isn't even all that is wrong with the code and your design (I haven't mentioned any code structure things yet)...
last but not least, unless you wrote these games yourself, you stole the ship.png asset from other games (I can't find it in any open art websites)
and its not last or least, most of your art assets from the 2d iso game are shamelessly stolen too (unless you own this repo). Yes it is MIT, but doing that it is nice to reference the source of the assets because as it stands it appears you made them yourself. Lets not forget the clause from MIT...
"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
I didn't bother checking the rest of the assets, but I can probably assume its the same situation.
Are you trying to write proper, clean C++ (which is what SFML aims at), and teachable code or just trying to get a book with your name on the cover? Writing bad C++ code and publishing it is a way to get your book on the do not read list.