search

Krukov / cashews

Cache with async power
MIT License
371 stars 22 forks source link

fix: do not check if tag registered just because it leads to difficulties #226

Closed Krukov closed 2 months ago

Krukov commented 2 months ago

Fix for https://github.com/Krukov/cashews/issues/225 and https://github.com/Krukov/cashews/issues/214

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.75%. Comparing base (c2d7e32) to head (830de31).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #226 +/- ## ========================================== - Coverage 93.79% 93.75% -0.05% ========================================== Files 54 54 Lines 3498 3490 -8 Branches 604 603 -1 ========================================== - Hits 3281 3272 -9 - Misses 108 109 +1 Partials 109 109 ``` | [Flag](https://app.codecov.io/gh/Krukov/cashews/pull/226/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Krukov+D) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Krukov/cashews/pull/226/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Krukov+D) | `93.63% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Krukov+D#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.