Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
395 stars 73 forks source link

[BUG] Logic Permissions for Request behave the same as Enabled #1214

Closed rexy712 closed 1 year ago

rexy712 commented 1 year ago

Describe the bug When setting up a teleporter or a door, under the permissions settings there is an option called 'Request'. When using this option for a door, a small popup appears when a player clicks to open a door which says 'Request to open door sent'. The problem is the door opens and the DM never receives a request to approve or deny. In effect this makes 'Enabled' and 'Request' behave identically.
The same issue exists for teleporters, but no 'Request to teleport sent' popup appears for the player.
This behavior is the same regardless of if you place 'default' or a specific player under the 'Request' section.

To Reproduce Steps to reproduce the behavior:

  1. Create a shape, enable door logic.
  2. Set permissions for default to Request.
  3. Player attempts to open the door.

Expected behavior A request should be sent to the GM for approval before a door or teleport is activated.

Screenshots Door behavior, which includes a request popup for the player. DM on left, Player on right.

https://user-images.githubusercontent.com/2442544/220448548-d5df5b4f-ace0-4bf0-a8d5-52a6813eafcb.mp4



Teleporter behavior which does not include a popup for the player. DM on left, Player on right.

https://user-images.githubusercontent.com/2442544/220448564-5d655da1-fdd8-4141-850e-5e4af4096b3b.mp4

Desktop: