search

Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
395 stars 73 forks source link

[BUG] Building mode selection does not move when another player moves a shape #1244

Open rexy712 opened 1 year ago

rexy712 commented 1 year ago

Describe the bug When in build mode, the outline of a selected shape is slightly different than in Play mode; it includes the rotation handle. If you have a shape selected while in build mode and another player moves that shape, the rotation handle and outline box don't move with the shape. It remains where the shape was until you reselect or deselect the shape. The part of the selection box that is also rendered in Play mode does move with the shape. So only part of it remains at the initial location. See the attached video because I'm having a hard time explaining this concisely.

To Reproduce Steps to reproduce the behavior:

  1. Create a shape, give move permissions to yourself and another player.
  2. Select the shape in build mode.
  3. Have the other player move the shape.
  4. The selection box does not move.

Expected behavior The selection box should fully move with the shape.

Screenshots

Player on right is moving the shape, player on left is in build mode with shape selected.

https://user-images.githubusercontent.com/2442544/226766382-6d9e2217-14a4-4f1a-bcf0-b87d2e4282f0.mp4

Desktop:

rexy712 commented 1 year ago

To add to this, if you zoom in or out while having a token selected in build mode, the rotation handle does not scale to match the new zoom level. So zooming in will make it get really big and zooming out will make it really tiny.

Kruptein commented 1 year ago

The zooming aspect has been resolved in #1252.

The actual issue with other players moving the shape is a bit more complex to solve in a clean way. I can probably hack it in pretty quickly if this is a big annoyance, but if not I want to tackle it more properly by reworking some internals, which will take a bit more time.

rexy712 commented 1 year ago

It's only happened to me once that I've noticed. I'm not super annoyed by it. Tbh the zooming part was worse once I noticed it, so thanks for fixing that so quick!
I'd say it'd be better to do a full solution than a quick hack. No rush.