Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
400 stars 73 forks source link

[BUG] Bold text in annotations is not bolded in firefox #1255

Closed rexy712 closed 1 year ago

rexy712 commented 1 year ago

Describe the bug When using markdown bold tag in the annotation text, firefox does not render the result as bolded. The text is bolded in chromium browsers.

To Reproduce Steps to reproduce the behavior:

  1. Create a shape
  2. Add an annotation with content **Bold**
  3. Hover mouse over the shape to see the annotation
  4. Text is not bolded.

Expected behavior Text in the annotation should be bolded as in chromium browsers.

Screenshots

firefox: firefox



ungoogled-chromium: ungoogled-chromium

Desktop:

Kruptein commented 1 year ago

The markdown rendering is done by another library, so this one I can't fix directly myself. The markdown lib we're using has been archived by now in favor of another one, which does not support the feature PA uses (dynamic md rendering), which makes the entire thing a bit messy.

I probably need to set aside some time to look into how I want to address this. One option is to bring in markdown-it myself directly.

develroo commented 1 year ago

Seems to be a repeat of my issue which we thought was fixed. But guess not.

Edit:

Oddly enough, it seems Tables do show the bold in Firefox Screenshot from 2023-04-05 10-00-35

Though it is definitely more obvious in Chrome/ium even the normal text in the annotation box appears bold, which, I suspect, is related.

Screenshot from 2023-04-05 10-04-52

Kruptein commented 1 year ago

Turns out it wasn't a fault in the library.

I'll still have to migrate to another library in the future however as the current one is no longer supported and superseded by another one, which is lacking the specific feature I was using.