Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
392 stars 71 forks source link

feat(Performance: ShapeSettings): Delay loading of most shape settings UI data #1261

Closed Kruptein closed 1 year ago

Kruptein commented 1 year ago

When you select a shape, the data that is displayed in the shape settings UI's various panels is already being loaded. This allows the dialog to open immediately showing data without having to wait for this data to load. It does however also mean that just swapping between some shapes performs these loads every time even when not used.

This PR changes the logic slightly to only grab the data of the active tab and wait with fetching more data until the relevant tab is opened. This retains the quick loading of the shape settings modal window with a smaller cost.

That said, this change will be mostly unnoticeable for most people.