Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
392 stars 71 forks source link

[BUG] Is Invisible toggle does not function until players reload the page #1262

Closed rexy712 closed 1 year ago

rexy712 commented 1 year ago

Describe the bug The 'Is invisible' toggle for shapes only makes the shape invisible after reloading the page. It also does not make things become visible when unchecking the box until a page reload.

To Reproduce Steps to reproduce the behavior:

  1. Create a Basic Token
  2. Check the box in shape properties > Is invisible
  3. Players can still see the shape.
  4. Have players reload the page. They can not see the shape anymore.

Expected behavior The Is invisible toggle should take effect when enabling/disabling rather than after a reload.

Screenshots

GM on left, normal player on right.

https://user-images.githubusercontent.com/2442544/232551878-7fa247ae-98bd-40e8-904d-3d485f51bf3b.mp4

Desktop:

Kruptein commented 1 year ago

This is very funny timing wise, because this exact bug happened in a game session I played in this weekend as well.

We also "resolved" it by refreshing, but I hadn't looked into what caused it. So thanks for logging this, seems like the message is not getting passed along to active connections.

Kruptein commented 1 year ago

Also sorry if it ruined something :C given that it relates to invisible stuff

rexy712 commented 1 year ago

No worries! I noticed it when my creature was supposed to be invisible and the players still knew where it was. I just started moving things to the DM layer to make them invisible.