search

Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
392 stars 71 forks source link

[FEAT] Show who rolled what in the log #1328

Closed Oreolek closed 5 months ago

Oreolek commented 7 months ago

The dice log is too terse and doesn't show who rolled what without hovering over each roll. I constantly need this info

Example: [user]: 1d6

SuikaXhq commented 5 months ago

I happen to have the same need and I have patched it in my own fork you can refer to: (https://github.com/SuikaXhq/PlanarAlly/commit/59df6f43e3c554403ba3af2b98c82bd73bb0b210) the patch also include your other issue #1327

Oreolek commented 5 months ago

i'm using the docker image so can't just use code patches or mods

SuikaXhq commented 5 months ago

sadly I haven't used the docker image so I can't help. I also think showing roll user and details is really useful when there are concurrent rolls. Hopefully a more decent update could make it.

Kruptein commented 5 months ago

I do have some things planned for the dice roller, but they are not progressing fast.

That said, @SuikaXhq why don't you submit a PR with your changes? It would be a nice help for some people.

SuikaXhq commented 5 months ago

well, in the beginning I was just patching for my own use so the code may look casual. I will submit a PR later.