Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
392 stars 71 forks source link

bug(Character): Fix multiple variant bugs #1348

Closed Kruptein closed 5 months ago

Kruptein commented 5 months ago

Variants/ToggleComposites are a common source of issues and the character system wanted to experience this as well.

This PR closes a bunch of bugs related to the use of shapes with variants as characters.

Variants are completely separate shapes behind the scenes currently and only one of them is getting marked as a character, which ended up causing funky bugs when another variant is active and you try to interact with the character system. This ranged from not being able to move a character by dropping it using the menu to actually removing shapes when deleting them instead of preserving them for later use.

This PR mostly prevents issues with shapes that are not bugged yet. So if you have some weird shenanigans already going on, you might have to remake the shape/character and get rid of the old ones.

As the variants system often introduces issues I'm likely going to do an overhaul to the entire shape system in the release following the next one so that these kind of issues are no longer a thing or will be caught way earlier.