search

Kruptein / PlanarAlly

A companion tool for when you travel into the planes.
https://www.planarally.io/
MIT License
393 stars 71 forks source link

feat(DiceTool): Resolve #1327, #1328 #1350

Closed SuikaXhq closed 5 months ago

SuikaXhq commented 5 months ago

Resolves #1327 Resolves #1328

Note that in client/src/game/dice/state.ts, I just use the first element of result list because I don't quite understand why the list always contains only one result item. Using the first item just works well.

Kruptein commented 5 months ago

Note that in client/src/game/dice/state.ts, I just use the first element of result list because I don't quite understand why the list always contains only one result item. Using the first item just works well.

The underlying dice API offers capabilities to do multiple rolls at the same time that should not be added together (e.g. 2d6+3 1d4-2, would do the 2 rolls at the same time and keep track of their underlying totals and subtotals as 2 separate entries).

The frontend UI of PA does not offer this option however so it's fine to take the first element only.

Kruptein commented 5 months ago

did you btw end up receiving my response to your mail?

SuikaXhq commented 5 months ago

are you referring to the email I sent to you on Oct. 17? It seems failed to receive your response as I haven't found any email related to that since then.

Kruptein commented 5 months ago

Oh, I'll try again then :V because I did reply to that mail