search

Krypton-Suite / Standard-Toolkit

An update to Component factory's krypton toolkit to support .NET Framework 4.6.2 - 4.8.1 to .NET 6 - 8
BSD 3-Clause "New" or "Revised" License
397 stars 60 forks source link

[Bug]: Ribbon bar does not integrate correctly with form when maximized #1572

Closed mbagattini closed 2 months ago

mbagattini commented 3 months ago

Describe the bug When a Ribbon control is added to a KryptonForm, it does not integrate correctly with the window chrome. Symptoms include:

To Reproduce

  1. Create a new Windows Forms project with .NET version 6.0
  2. Reference Krypton, e.g. version 85.24.6.176
  3. Make Form1 a KryptonForm
  4. Drop a Ribbon control
  5. Start the application, maximize the window

Expected behavior A seamless integration between the Ribbon control and the form, in terms of colors. Form that follows the palette set for it. When maximized, window title should be displayed only once.

Screenshots image

Desktop (please complete the following information):

Additional context Issue has been discussed here: #1549 The discussion also contains a sample program

PWagner1 commented 3 months ago

Hi @mbagattini & @giduac

One thing to note that in V90, we have completely ripped out the old Aero stuff, as it doesn't work well with Windows 10/11. That's probably why there's an inconsistency between V80/85 & V90.

giduac commented 3 months ago

@Wagnerp

Now what shall we do, have @mbagattini use a v90 canary build?

PWagner1 commented 3 months ago

@Wagnerp

Now what shall we do, have @mbagattini use a v90 canary build?

@giduac

If @mbagattini can test again using canary build .176 then it should solve this issue.

giduac commented 3 months ago

@Wagnerp

So a fix for V85 is not realistic atm?

PWagner1 commented 3 months ago

@Wagnerp

So a fix for V85 is not realistic atm?

@giduac

No, as a lot of code + fixes had to be redone.

mbagattini commented 3 months ago

If @mbagattini can test again using canary build .176 then it should solve this issue.

I'd be happy to try it, I just need a tip about how to make it visible in my VS packages list, since even if I enable "Include pre-releases" NuGet only lists up to 85.24.6.176.

PWagner1 commented 3 months ago

@giduac

This looks like a duplicate of issues: #1301, #1188 & #1145

giduac commented 3 months ago

1188 clearly about this Definitely worth a look if this is a regression, a fix might be possible for V85 in that case.

PWagner1 commented 3 months ago

Hi @giduac

This is the PR I was talking about https://github.com/Krypton-Suite/Standard-Toolkit/pull/1288. I would hold off backporting it, as it does contain some significant code & designer changes, but it does solve this issue.

giduac commented 3 months ago

Hi @Smurf-IV,

Can you please have look at this to see if this is feasible to fix or that it would be better for @mbagattini to move forward to V90 Canary. Thanks

Smurf-IV commented 3 months ago

If @mbagattini can test again using canary build .176 then it should solve this issue.

I'd be happy to try it, I just need a tip about how to make it visible in my VS packages list, since even if I enable "Include pre-releases" NuGet only lists up to 85.24.6.176.

Just add Canary to your search string within the nuget package manager, And then replace all Krytpon packages you are currently using with the latest:

image

PWagner1 commented 3 months ago

Hi @Smurf-IV,

Can you please have look at this to see if this is feasible to fix or that it would be better for @mbagattini to move forward to V90 Canary. Thanks

I would just add canary as pushing the changes into v85 now will break a lot of stuff for developers.

giduac commented 2 months ago

Hi @Wagnerp, Please close as there's no further feedback, ty