search

Krypton-Suite / Standard-Toolkit

An update to Component factory's krypton toolkit to support .NET Framework 4.6.2 - 4.8.1 to .NET 6 - 8
BSD 3-Clause "New" or "Revised" License
374 stars 56 forks source link

[Bug]: "MS365 - Black" theme is unreadable #1607

Closed Smurf-IV closed 1 week ago

Smurf-IV commented 2 weeks ago

Using today's alpha, and the test app, the MS365 - Black theme is unreadable in both active and non focused states:

image

And Active: image

Wagnerp commented 2 weeks ago

Hi @Smurf-IV

This is the value you want to play around with...

   SystemColors.Control, // InputControlBackDisabled
Smurf-IV commented 2 weeks ago

This is the value you want to play around with...

   SystemColors.Control, // InputControlBackDisabled

What has this to do with the theme colours ?

Wagnerp commented 2 weeks ago

This is the value you want to play around with...

   SystemColors.Control, // InputControlBackDisabled

What has this to do with the theme colours ?

It's within the colours array of the theme, and controls the 'disabled' bg colour

Smurf-IV commented 2 weeks ago

Noting should be using SystemColors.Control as different people have different backgrounds etc (i.e. Dark OS themes have nothing to do with Dark Krypton themes) And if the user has a light OS theme, then those system colours are going to be "Very wrong" for use with Dark Krypton themes.

Wagnerp commented 2 weeks ago

Noting should be using SystemColors.Control as different people have different backgrounds etc (i.e. Dark OS themes have nothing to do with Dark Krypton themes) And if the user has a light OS theme, then those system colours are going to be "Very wrong" for use with Dark Krypton themes.

I think this has existed in previous themes since 4.x

then those system colours are going to be "Very wrong" for use with Dark Krypton themes.

No, as these were changed in PR #1587 to be colour appropriate

Wagnerp commented 2 weeks ago

@Smurf-IV

I think this should be more of a Bug/FR, since it's a legacy thing that needs updating to match modern design principals, i.e. dark/light modes introduced with Win 10.

Thoughts @giduac?

giduac commented 2 weeks ago

@Wagnerp & @Smurf-IV

There are a lot of those tickets.

@Wagnerp , can you make a concise overview of things you run into when fine tuning themes and maybe also defining the main color setup of themes.

So we can look into this together and what can be done about it.

Wagnerp commented 2 weeks ago

@giduac

can you make a concise overview of things you run into when fine tuning themes and maybe also defining the main color setup of themes.

Will post it in the discussions

giduac commented 2 weeks ago

Probably open a discussion where we can dig down a little deeper into this...

Wagnerp commented 2 weeks ago

Probably open a discussion where we can dig down a little deeper into this...

Hi @Smurf-IV & @giduac

Please see https://github.com/Krypton-Suite/Standard-Toolkit/discussions/1608 for how theme colours work

Wagnerp commented 1 week ago

Hi @Smurf-IV & @giduac

I now know where to fix this. Do you want me to apply the same fixes for the O2k7/10 themes as well, or leave them be?

Smurf-IV commented 1 week ago

My vote is to: Fixing themes is the focus for v90

Wagnerp commented 1 week ago

Fixed, PR incoming

image