Krypton-Suite / Standard-Toolkit

An update to Component factory's krypton toolkit to support .NET Framework 4.6.2 - 4.8.1 to .NET 6 - 8
BSD 3-Clause "New" or "Revised" License
388 stars 57 forks source link

[Bug]: DataGridView ComboBox Adding list over and over #996

Closed DavidLanham closed 9 months ago

DavidLanham commented 1 year ago

Krypton.Toolkit.KryptonDataGridView and KryptonDataGridViewComboBoxColumn producing a strange behavior.

  1. Click on the combo box and cause the list to pop down
  2. Don't select anything from the list.
  3. Click off somewhere else causing the list to close
  4. Click on the combo box again and cause the list to pop down again.
  5. Now the list has duplicated itself.
  6. You can keep doing this and the list keeps duplicating

I have tried this will all version of the Krypton Toolkit. Knightly, Canary, stable. They all produce the same behavior'.

If I change the ColumnType to use DataGridViewComboBoxColumn instead of the KryptonDataGridViewComboBoxColumn it does not duplicate the list, it works correctly.

PWagner1 commented 1 year ago

Hi @DavidLanham

Thanks for reporting, is it possible to post a screen recording of the bug?

DavidLanham commented 1 year ago

Here you go

https://user-images.githubusercontent.com/114610313/232265436-cae5f4f4-749d-47d0-81a8-e368ea1a1472.mp4

DavidLanham commented 1 year ago

https://user-images.githubusercontent.com/114610313/234270191-833d86ad-86e2-4aff-8274-c8e65a3d3fea.mp4

So I was playing around with this issue and I figure something else out that may be helpful when looking at this issue

varshneydevansh commented 1 year ago

This bug seems like a little beginner-friendly, can I look into this?

Smurf-IV commented 1 year ago

This bug seems like a little beginner-friendly, can I look into this?

Assign this to yourself, and set to in-progress etc. Make a branch from alpha Name it like alpha-996-DGVComboBox Work on it. Create PR Show that it builds via the run command in the root directory (alpha build option) by adding a screenshot

Make sure that the Demo's still work.

Have a look at past PR's for the commenting screenshot styles

DavidLanham commented 9 months ago

How can I check if this has been fixed?

PWagner1 commented 9 months ago

How can I check if this has been fixed?

@DavidLanham I don't think it's been fixed yet @Smurf-IV any ideas?

PWagner1 commented 9 months ago

@DavidLanham Have you tried setting a breakpoint, then stepping through to see where it gets duplicated?

DavidLanham commented 9 months ago

I am not sure that I am good enough programmer to do this. I have downloaded the Master code and opened it in VS2022. I have added my project to the Solution and I am able to start my project with reference to the Master Project. Can you suggest where in the Source\Krypton.Toolkit 2022 code to look?

Smurf-IV commented 9 months ago

Still there: StrangeDropBox

Smurf-IV commented 9 months ago

@DavidLanham

Here you go Krypton.DataGridView.Combo.Error.mp4

Your videos are not visible to anyone (Probably you can see them:) image

Use ScreenToGif and upload those please ?

PWagner1 commented 9 months ago

@Smurf-IV Which browser are you using, as I can see them?

image

Smurf-IV commented 9 months ago

Firefox.

Smurf-IV commented 9 months ago

PR in Coming: FixDropClickOff

DavidLanham commented 9 months ago

I am sorry not sure what you mean, did you make a change or is there something that I am not going correctly? If you made a change would it be in the Nightly build? Can I test it? Thanks for looking at this.

Smurf-IV commented 9 months ago

I am sorry not sure what you mean, did you make a change

Yes, Hence the PR reference above.

or is there something that I am not going correctly?

No, you where doing stuff fine, because it was replicated in the Example code that is used Krypton.

If you made a change would it be in the Nightly build? Can I test it?

Yes, It should be in the nightly build that has a number greater than 337 (Not done yet..)

PWagner1 commented 9 months ago

I am sorry not sure what you mean, did you make a change or is there something that I am not going correctly? If you made a change would it be in the Nightly build? Can I test it? Thanks for looking at this.

Hi @DavidLanham

Please retry using nightly >= 338. Please be aware that there are some breaking changes in this build, documented in the 'alpha' Readme.

DavidLanham commented 9 months ago

I used the Nightly 338 and it worked. Thank you for looking into this and making the change. No hurry, but when do you think it will make it to the stable release?

PWagner1 commented 9 months ago

Hi @DavidLanham

No hurry, but when do you think it will make it to the stable release?

Not until v90 is complete (November 2024), we're trying to be much stricter about branches to avoid conflicts/'merge hell' etc. However you can use canary builds in the meantime, as they're slightly more stable.