KryptoniteDAO / krp-cdp-contracts

Kryptonite stable coin kUSD relevant contracts
0 stars 0 forks source link

assert_fees function is not applied correctly #15

Closed smithmonnnnnnn closed 10 months ago

smithmonnnnnnn commented 11 months ago

Description: "The assert_fees function in update_config from liquidation_queue contract is not applied correctly. As a consequence, some valid values will not be accepted, see example below:

Current values:

New values:

The new values won't be accepted despite that 0.5 + 0.4 < 1. The assert_fees function should be applied after trying to change both values (bid_fee and liquidator_fee).

Code Location: krp-cdp-contracts/contracts/liquidation_queue/src/contract.rs#L211-L219