search

Kryptos-FR / markdig.wpf

A WPF library for xoofx/markdig https://github.com/xoofx/markdig
MIT License
162 stars 52 forks source link

Update to Markdig 0.21.1 #42

Closed amkuchta closed 3 years ago

amkuchta commented 4 years ago

Currently, I am unable to update to the latest version of Markdig (0.21.1), as it is deemed to be incompatible with the latest release of Markdig.Wpf (0.3.1)

Kryptos-FR commented 4 years ago

I have to use an exact version each release because of #20 (related to https://github.com/lunet-io/markdig/issues/274).

And now, on top of that, Markdig have decided do drop support for .NET Framework 4.0 which was requested by another user (#25) and is currently being discussed in #41.

Kryptos-FR commented 4 years ago

Despite #20, I will relax the dependency rule. It might break sometimes, but at least it won't prevent to upgrade to a later version when it still works.

edit: rule relaxed in version 0.4.0. I was able to upgrade up to Markdig 0.20.0, however 0.21.0 breaks with some MissingMethodException so it will need some updates before you can use it. I plan to do so in the next version.

tjdennis commented 3 years ago

Hi. Is there any update coming to this project that fixes the MissingMethodException? Markdig is now at 0.22.0 and I would love to be able to use your project for displaying markdown files instead of bouncing them through HTML. I am seeing the error with Markdig 0.20.0 as well.

The missing method "Write" is there and hasn't changed. Maybe you're missing some new interface method or it's a difference in your Render signature that's causing the underlying RenderBase class from instantiating. You have a [NotNull] in yours.

Thanks!

Kryptos-FR commented 3 years ago

@tjdennis I pushed version 0.5.0. Can you tell me if it works for you?

Mertsch commented 3 years ago

For me Markdig.Wpf 0.5.0 works great with Markdig 0.22 and 0.22.1

Kryptos-FR commented 3 years ago

@Mertsch thanks for confirming. I'll keep this issue open until #43 is resolved.

Kryptos-FR commented 3 years ago

Closing as #43 is now resolved.