search

KrystalJean / henry-game

Based off a '90s electronic handheld game where you have to find the matching sound.
3 stars 4 forks source link

Improve the Game Console style #2

Open KrystalJean opened 2 years ago

KrystalJean commented 2 years ago

Improve the game console style to look more like the real thing. Please, check the README.md for current screenshots of the progress, and the look we are going for.

The game console is the blue area. For now I just have a square with rounded corners as a placeholder as I work on the JavaScript/logic part of the game. I am looking for someone who can get the shape better.

Notice in the attached image how the corners have the cut out area that dips in, and the long sides curve out a little rather than a straight line. This is more like an octagon, sort of.

Also, the little speaker vent lookin' things in the corners (the tiny notches) and on the left and right sides (the three horizontal lines) would be a nice to have.

We can split the work up if needed, and take multiple merges, if for example, one person feels comfortable working on the shape of the game console, and another person wants to work on the speaker vent detail.

Note: When I say split up the work, I do not mean asking to merge a request saying that you changed the shade of blue, or changed the padding from 2px to 3 px.

AyushRaghuvanshi commented 2 years ago

Hello @KrystalJean I would like to work on this issue, I am thinking of trying to add some shadows to the button and console and also work on the shape as you asked.

KrystalJean commented 2 years ago

Hi @AyushRaghuvanshi . I have assigned you for this issue. Please hold off on any work on the buttons because I do have separate issues for those, but the rest sounds good.

AyushRaghuvanshi commented 2 years ago

ok, I'll keep that in mind.

jqaustin commented 2 years ago

can I improve the game console?

KrystalJean commented 2 years ago

Hi @jqaustin , sure let me know if you have any questions?

KrystalJean commented 2 years ago

This is a bigger issue, so multiple pull requests to improve this are welcome, as long as the improvement is a quality contribution, and really helps upgrade the look in a big way.