Ks89 / angular-modal-gallery

Modal image gallery for Angular
https://ks89.github.io/angular-modal-gallery-2024-v12.github.io/
MIT License
146 stars 80 forks source link

Support for PDF viewer #178

Open shaamcom83 opened 5 years ago

shaamcom83 commented 5 years ago

Would be good when this plugin be used for previewing and downloading pdfs as well.

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

My official live example on StackBlitz (based on https://stackblitz.com/edit/angular-modal-gallery-v7) is:

What is the motivation / use case for changing the behavior?

Environment (the most important section to fill very carefully)


- @ks89/angular-modal-gallery version: X.X.X
- Node version: X.X.X  
- npm version: X.X.X  
- Operating System and version:  
- Angular version: X.Y.Z 
- angular-cli version (or SystemJS/Webpack): X.Y.Z 
- I'm using Server Side Rendering with angular-universal: YES/NO
- I'm compiling with mode: DEBUG / PROD / PROD with AOT



Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

Ks89 commented 5 years ago

Hi! Honestly I'm not an expert about PDFViewer and how to integrate it into a <div>.

The best way to do this is probably start experimenting a cross browser way to show PDFs in a div with fixed width and height and then try to merge it into the library.

To do this I need help, so a repo with some working examples supporting browsers >= IE11. Then, if the result is good, I can try to merge it into the library.

I cannot set high priority to this, because I already scheduled the todo list for version 8.0.0.

Would you contribute to this?