Update carousel config in ngOnChanges

Ks89 / angular-modal-gallery

Modal image gallery for Angular

https://ks89.github.io/angular-modal-gallery-2024-v12.github.io/

MIT License

146 stars 80 forks source link

Update carousel config in ngOnChanges #269

Open Dea1100 opened 2 months ago

Dea1100 commented 2 months ago

https://github.com/Ks89/angular-modal-gallery/blob/282c69e8cb60d917278178cb3e78f1dae78600b8/projects/ks89/angular-modal-gallery/src/lib/components/carousel/carousel.component.ts#L294

Why is this commented out? Is it possible to change this so that the config is also updated in ngOnChanges?

Ks89 commented 2 months ago

Hi, good question, I don't remember this.

Which kind of behaviour are you trying to implement? What is your scenario?

Dea1100 commented 3 weeks ago

Hi, sorrry for my late reply. My use case is that I have a gallery instance where I dynamically change the config, without destroying the component. Hence, the config does not change since it is only set in ngOnInit.