search

Ks89 / angular-modal-gallery

Modal image gallery for Angular
https://ks89.github.io/angular-modal-gallery-2024-v12.github.io/
MIT License
146 stars 80 forks source link

Initial support for SSR with angular universal #81

Closed Ks89 closed 6 years ago

Ks89 commented 7 years ago

Scheduled for version 4.0.0

Ks89 commented 7 years ago

Already supported here https://github.com/Ks89/angular-webpack2-starter-demo-with-angular-modal-gallery

It is working also with 3.x.x, but only on that starter.

I should create a minimal starter and put it into demo's folder.

Ks89 commented 7 years ago

Server-Side-Rendering (SSR) partially implemented in angular-modal-gallery 5.0.0. I still have a non blocking issue about Mousetrap. Also I added an official example with angular-universal.

Ks89 commented 7 years ago

I should try this solution to provide "window": https://github.com/mlent/vanilla-universal-starter/blob/master/server.js

Ks89 commented 6 years ago

I decided to release it in version 5.0.0, however angular-universal still doesn't support 'window' object on server side, so I cannot add the full official support.

I you want to try, you'll see that the library itself is working, but your server's log will be polluted with stupid error messages.

When Angular team will add 'window' object on server-side, this library will work automatically without other modifications. For this reason I decided to mark this issue as closed.