search

KshitijDarekar / Codeditor

An online code-editor for HTML, CSS, JS code snippets.💻✨
https://coditor.netlify.app
MIT License
2 stars 2 forks source link

Added copy to clipboard function, responsive landing page and implemented routes #8

Closed Aniket-508 closed 2 years ago

Aniket-508 commented 2 years ago

Closes #5 , #3 , #1

Aniket-508 commented 2 years ago

@KshitijDarekar Kindly review this PR.

KshitijDarekar commented 2 years ago

@Aniket-508 issue[#1 ] was already assigned to someone else. It won't be a problem if the assignee hasn't started working on it already but do check out if any issue is taken up by someone already the next time, to avoid conflicts.

Aniket-508 commented 2 years ago

@KshitijDarekar I have added inline-flex on the line 40. And regarding the issue 1, the assignee has already given green signal to assign it to someone else. Maybe you can merge this PR then. One more request, can you make the Landing page as difficult since I also made it responsiveness and for all other issues that this PR solves, you can keep them as you want.

KshitijDarekar commented 2 years ago

@Aniket-508 any update?

Aniket-508 commented 2 years ago

@KshitijDarekar I have already done that. Please read the comments above.

KshitijDarekar commented 2 years ago

@KshitijDarekar I have already done that. Please read the comments above.

you have added the classbutton-group-editor in the last commit, but I can't see the CSS for the same .🤔

Aniket-508 commented 2 years ago

@KshitijDarekar Extremely sorry, I forgot to stage that file. Now it is done.