Right now if you expect it to throw and want to purposefully ignore it, it's impossible since the console.error() is inside the method.
This package says the method returns a promise, but it actually returns a promise that can never fail and could be empty, which goes against the normal JS workflow for promises and async/await. Right now the error gets swallowed and hidden from the devs.
So this PR allows the method to fail and the caller to handle the error as they see fit, as usual with JS promises.
Please let me know if you'd like the same for the other method.
Edit: the DIff seems all wrong, but I just removed the try/catch and removed an indentation level 🤷
Right now if you expect it to throw and want to purposefully ignore it, it's impossible since the
console.error()
is inside the method.This package says the method returns a promise, but it actually returns a promise that can never fail and could be empty, which goes against the normal JS workflow for promises and async/await. Right now the error gets swallowed and hidden from the devs.
So this PR allows the method to fail and the caller to handle the error as they see fit, as usual with JS promises.
Please let me know if you'd like the same for the other method.
Edit: the DIff seems all wrong, but I just removed the
try/catch
and removed an indentation level 🤷