search

Kuadrant / authorino-operator

Kubernetes Operator to manage Authorino instances
Apache License 2.0
9 stars 20 forks source link

Tighten API group specification for RBAC #111

Closed willthames closed 1 year ago

willthames commented 1 year ago

When possible it's much better to explicitly specify RBAC constraints, in particular for APIGroups, Resources and Verbs where the set of possibilities is limited to start with

Specify the API group for all RBAC permission requirements.

willthames commented 1 year ago

There is an outstanding question of whether events should be in the core API group (i.e. "") or the new events type events.k8s.io. For most event consumption purposes, the core group is likely correct but if you want to publish events events.k8s.io seems to be more common.

guicassolato commented 1 year ago

Hi @willthames. Your PR looks good and I'll be glad to merge it. Thank you so much for your contribution!

Would you mind running make bundle? It's just so it updates the CSV too, at bundle/manifests/authorino-operator.clusterserviceversion.yaml.

Cheers!

willthames commented 1 year ago

Thanks @guicassolato - I've run make bundle now and re-pushed.