search

Kuadrant / authorino-operator

Kubernetes Operator to manage Authorino instances
Apache License 2.0
9 stars 20 forks source link

Include commit SHA for related images in the operator catalog #121

Closed didierofrivia closed 1 year ago

didierofrivia commented 1 year ago

At the moment, in the task creating the catalog, there's only a distinction when the build is for main or a release branch, tagging the catalog related images as latest and the specific vX.Y.Z release tag... but there's no condition for the SHA tagged build.

The current latest SHA build is rendered as:

bin/opm render quay.io/kuadrant/authorino-operator-catalog:30fb663ddc5b2978add48fd6ee9ff526317c05a5 --output=yaml

...

---
entries:
- name: authorino-operator.v0.0.0
name: alpha
package: authorino-operator
schema: olm.channel
---
image: quay.io/kuadrant/authorino-operator-bundle:latest # This should be quay.io/kuadrant/authorino-operator-bundle:30fb663ddc5b2978add48fd6ee9ff526317c05a5
name: authorino-operator.v0.0.0
package: authorino-operator
properties:
...

relatedImages:
- image: quay.io/kuadrant/authorino-operator:latest  #This should be quay.io/kuadrant/authorino-operator:30fb663ddc5b2978add48fd6ee9ff526317c05a5

...

Putting aside that this operator should build the catalog with the new file system instead of the current deprecated Sqlite-based one, the proposed change would be to include the SHA commit as a tag in the GH action that creates the catalog in .github/workflows/build-images.yaml and possibly make changes in the invoked target in the Makefile