search

Kuadrant / authorino

K8s-native AuthN/AuthZ service to protect your APIs.
Apache License 2.0
201 stars 32 forks source link

Added support for s390x & ppcl64e architecture #467

Closed modassarrana89 closed 5 months ago

modassarrana89 commented 6 months ago

Updated Github workflow to support multi-arch

gitguardian[bot] commented 6 months ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11389370](https://dashboard.gitguardian.com/workspace/3149/incidents/11389370?occurrence=139722261) | Triggered | Username Password | 41697e16221d6b92f4fb2de2d2f78ea10fb38ca9 | .github/workflows/build-images.yaml | [View secret](https://github.com/Kuadrant/authorino/commit/41697e16221d6b92f4fb2de2d2f78ea10fb38ca9#diff-6ec9d6ffc2c8ebd369edcc698ad16020762b6616d45849d4b539557e59563884L50) | | [11389370](https://dashboard.gitguardian.com/workspace/3149/incidents/11389370?occurrence=139722262) | Triggered | Username Password | 89bc66ab26c0cec1ebdb5bbf04b96e24a363850b | .github/workflows/build-images.yaml | [View secret](https://github.com/Kuadrant/authorino/commit/89bc66ab26c0cec1ebdb5bbf04b96e24a363850b#diff-6ec9d6ffc2c8ebd369edcc698ad16020762b6616d45849d4b539557e59563884L50) | | [11389370](https://dashboard.gitguardian.com/workspace/3149/incidents/11389370?occurrence=139722263) | Triggered | Username Password | 64c8e1648a264d5b8f5acfed2a2571601a330668 | .github/workflows/build-images.yaml | [View secret](https://github.com/Kuadrant/authorino/commit/64c8e1648a264d5b8f5acfed2a2571601a330668#diff-6ec9d6ffc2c8ebd369edcc698ad16020762b6616d45849d4b539557e59563884L50) | | [11389370](https://dashboard.gitguardian.com/workspace/3149/incidents/11389370?occurrence=139722264) | Triggered | Username Password | e1e2aa68f09e93c4739f8724ab9bd2ff1e2a25b5 | .github/workflows/build-images.yaml | [View secret](https://github.com/Kuadrant/authorino/commit/e1e2aa68f09e93c4739f8724ab9bd2ff1e2a25b5#diff-6ec9d6ffc2c8ebd369edcc698ad16020762b6616d45849d4b539557e59563884R50) | | [11389371](https://dashboard.gitguardian.com/workspace/3149/incidents/11389371?occurrence=139722260) | Triggered | Generic High Entropy Secret | 0b85b788c3cc2d91216c844c3d997c4ed8b9eb90 | .github/workflows/build-images.yaml | [View secret](https://github.com/Kuadrant/authorino/commit/0b85b788c3cc2d91216c844c3d997c4ed8b9eb90#diff-6ec9d6ffc2c8ebd369edcc698ad16020762b6616d45849d4b539557e59563884R65) | | [11389371](https://dashboard.gitguardian.com/workspace/3149/incidents/11389371?occurrence=139722265) | Triggered | Generic High Entropy Secret | e1e2aa68f09e93c4739f8724ab9bd2ff1e2a25b5 | .github/workflows/build-images.yaml | [View secret](https://github.com/Kuadrant/authorino/commit/e1e2aa68f09e93c4739f8724ab9bd2ff1e2a25b5#diff-6ec9d6ffc2c8ebd369edcc698ad16020762b6616d45849d4b539557e59563884L65) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/username_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

modassarrana89 commented 6 months ago

@jasonmadigan @thomasmaas @maleck13 @alexsnaps Please review changes

guicassolato commented 6 months ago

Thanks for the PR @modassarrana89.

I'm running the workflow now: https://github.com/Kuadrant/authorino/actions/runs/9303477739/job/25605860414

Let's see how it goes.

modassarrana89 commented 6 months ago

Thanks for the PR @modassarrana89.

I'm running the workflow now: https://github.com/Kuadrant/authorino/actions/runs/9303477739/job/25605860414

Let's see how it goes.

Thanks. It has run successfully by the way.

modassarrana89 commented 6 months ago

@guicassolato I have raised another PR ( https://github.com/Kuadrant/authorino-operator/pull/181 ) with similar changes for authorino operator