Closed alexsnaps closed 2 months ago
@guicassolato wdyt: should I add the controller changes to this PR?
Other than me missing something, I think we should keep this PR as one individual change, and the controller one as another... I started and it'll be quite a big change in itself... With that in mind, marking this as ready for review
@alexsnaps, can you please run make generate manifests
?
There are still a few RBAC manifests that should not be part of this change.
@alexsnaps, can you please run
make generate manifests
?There are still a few RBAC manifests that should not be part of this change.
I think this is still not doing what you expect... I'm unsure what you are referencing here but make generate manifests
"merely" changed these 2 lines in deepcopy 🤔
I scratched all in ./bin
, but same behavior... can you try locally see if you achieve some other results?
Unsure whether we want to change the controller to use v1beta2 as part of this PR or a different one...
Partially fixes #479 - need to update the controller logic to use the new API