Kuadrant / dns-operator

Kuadrant DNS Operator
Apache License 2.0
1 stars 9 forks source link

DNSHealthCheckProbe is not removed if healthcheck definition deleted #306

Open maleck13 opened 5 hours ago

maleck13 commented 5 hours ago

What

When the DNS operator reconciles health checks it does not check when the healthcheck is nil if a health check was previously created. This means when a healthcheck spec is removed the related DNSHealthCheckProbe is not also removed

How

The fix for this is change the logic under ReconcileHealthChecks where when the healthcheck is nil it should check if a probe was created before returning.

maleck13 commented 5 hours ago

@trepel you can track this here