Add policies page - Githubissues

david-martin commented 1 month ago

Closes #17

TODO:

[x] add policy type tab selector to top of page, including 'all policies' tab
[x] implement single policy type view
[x] implement all policies view
[x] add name/label filter input to top of page
[x] add kebab menu for each policy item in list views - link to edit/delete etc... (initially no link if pages don't exist) (based on example at https://www.patternfly.org/components/menus/dropdown#with-kebab-toggle)
[x] add blue info box to top of page
[x] review fields being show for each policy type in list view, ensuring most relevant/useful are shown - Using 'Created' as a formatted timestamp (like other resource lists in console) and a Status conditions summary string e.g. "Accepted=True,Enforced=True"
[x] fix 404 when a single project is selected in project dropdown (works for 'all projects') - No longer 404s, but always routes back to the 'All policies' tab. Deferring how to get it to stick to the open tab when switching project context for now.
[x] copy or reuse page for both admin & dev perspective, with just auth/ratelimit shown for dev perspective
[ ] ~fix page reload issue when typing in filter input~ (defer at this time, low priority)

david-martin commented 1 month ago

I'd like to checkpoint the work in this PR and get it merged if possible as I believe it satisfies the majority of the ask and aligns to the mockups for the most part. Screenshots of the view included below, and a list of some things that can be addressed in follow up PRs as more adjacent changes land (I could see us doing a larger combined review of changes and making a snag list for example).

All Policies page

Single Policy type page

Potential follow up changes

Add actions and links to the table rows kebab menu (depends on #34 and #16)
Link to custom 'Create Policy' pages (depends on #34)
Content for info boxes at top of pages, and decide on behaviour (dismissable alert type box, or always visible)
Review for I18n & all relevant text strings
Decide on what 'View' page to link to (custom page?). Currently uses ResourceLink which links to a built in page like /k8s/ns/ingress-gateway/kuadrant.io~v1alpha1~DNSPolicy/loadbalanced-dnspolicy
When switching project in the dropdown, keep the same tab context instead of always routing back to the 'All policies' tab
Multi option create button (see mockup below)
Paginator at bottom of lists (see mockup below)