search

Kuadrant / kuadrant-console-plugin

Apache License 2.0
2 stars 2 forks source link

Add RateLimitPolicy create page #63

Closed david-martin closed 4 weeks ago

david-martin commented 1 month ago

Closes #31

Screenshots below. A few fields have been purposefully left out of the form view as the API will be changing for kuadrant v1. Future changes to the from are captured in https://github.com/Kuadrant/console-plugin/issues/68 In the interim, an info message is shown to direct the user to the yaml view for more complex limits configuration beyond simple limits.

Create form

image

Add Limit modal

image

 Limits in form

image

 Yaml editor

image

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/console-plugin/blob/main/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
david-martin commented 4 weeks ago

@jasonmadigan thanks for reviewing. I've pushed up recommended changes. Also added i18n strings.

jasonmadigan commented 4 weeks ago

Changes look good, let me give it a quick spin again

jasonmadigan commented 4 weeks ago

Works good, noticed one small thing - the edit action in the RLP list view doesn't seem to navigate to edit

Screenshot 2024-09-13 at 16 06 52

david-martin commented 4 weeks ago

the edit action in the RLP list view doesn't seem to navigate to edit

I'd say that's the same for all Edit buttons? There's a separate issue to figure out reusing the create view as an edit view #59

jasonmadigan commented 4 weeks ago

Must've had a fever dream where I thought some of these worked - nevermind so!

/lgtm