Kuadrant / kuadrant-console-plugin

Apache License 2.0
2 stars 2 forks source link

Fix showing of server side validation error response in RLP & DNS cre… #70

Closed david-martin closed 3 weeks ago

david-martin commented 3 weeks ago

…ate views

closes #58

The Create button on the DNS & RLP pages is disabled until the name, namespace and targetRef are set. After that, if there's an error when you click create, it will show an alert box below the form (see screenshot for example)

The changes also include the removal of the custom save function for DNSPolicy via the yaml editor as it isn't required (it was originally added as I thought it was needed to convert matchLabels from an object to an array, and back again at the right time for yaml saving, but that's only the case for the form view). Making this change allows the yaml editor to fall back to the built in save function for that component, which handles creation and showing validation errors.

image

TODO:

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/console-plugin/blob/main/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jasonmadigan commented 3 weeks ago

👀

jasonmadigan commented 3 weeks ago

/lgtm