Closed eguzki closed 2 years ago
is this ready for review?
It's ready for review, but still WIP.
@rahulanand16nov the PR is fully implemented. Ready for final review and merge if approved
Wow, that was a long PR! looking good overall +1
Sorry about that! It should not be like that.
what
RateLimitPolicy implementing Gateway API's Policy Attachment Target Reference API
Currently only HTTPRoutes can be targeted.
Additionally:
make help
Verification Steps
Follow Getting Started
Fixes #123
Verification Steps (referenced gateway changes)
The PR includes a deployment of a second gateway with key
kuadrant-system/other-gwapi-gateway
Deploy
toystore
HTTPRoute with parentRefkuadrant-gwapi-gateway
Deploy
carstore
HTTPRoute with parentRefkuadrant-gwapi-gateway
Deploy
toystore
RLP with targetReftoystore
HTTPRouteDeploy
carstore
RLP with targetRefcarstore
HTTPRouteThere is only one WASM envoyfilter associated to
kuadrant-gwapi-gateway
gatewayThe envoyfilter
kuadrant-kuadrant-gwapi-gateway-wasm-ratelimits
associated tokuadrant-gwapi-gateway
gateway has ratelimit configuration from bothtoystore
andcarstore
RLP objects. Theratelimitpolicies
object has two keys:default/carstore
anddefault/toystore
, the RLP object names.Change
toystore
HTTPRoute parentRef fromkuadrant-gwapi-gateway
gateway toother-gwapi-gateway
gatewayThe kuadrant control plane has removed
toystore
RLP config from the envoyfilterkuadrant-kuadrant-gwapi-gateway-wasm-ratelimits
associated tokuadrant-gwapi-gateway
gateway. This envoyfilter only contains config fromcarstore
RLP.The kuadrant control plane has added
toystore
RLP config to the envoyfilterkuadrant-other-gwapi-gateway-wasm-ratelimits
associated toother-gwapi-gateway
gateway.carstore
HTTPRoute parentRef fromkuadrant-gwapi-gateway
gateway toother-gwapi-gateway
gatewaycarstore
RLP config from the envoyfilterkuadrant-kuadrant-gwapi-gateway-wasm-ratelimits
associated tokuadrant-gwapi-gateway
gateway. As the envoyfilter has no config from any rate limit policy, the control plane deletes the envoy filter. Only the envoyfilter associated to theother-gwapi-gateway
gateway exists.TODO