Kuadrant / kuadrant-controller

Apache License 2.0
12 stars 7 forks source link

AuthPolicy: Add status block #173

Closed rahulanand16nov closed 2 years ago

rahulanand16nov commented 2 years ago

155

This PR:

  status:
    conditions:
    - lastTransitionTime: "2022-06-29T12:23:14Z"
      message: HTTPRoute is protected
      reason: HTTPRouteProtected
      status: "True"
      type: Available
    observedGeneration: 1
  status:
    conditions:
    - lastTransitionTime: "2022-06-29T12:23:14Z"
      message: Gateway is protected
      reason: GatewayProtected
      status: "True"
      type: Available
    observedGeneration: 1

Note: If for some reason, AuthConfig is not ready when AuthPolicy is reconciling, it will say AuthConfigNotReady, but the status update will only happen in the next reconciliation event because IIRC, we cannot watch the status block of a resource (correct if I am wrong here).

maleck13 commented 2 years ago

Are we consistent with the RLP? I am assuming yes but wanted to check that the user experience is at least similar from a status point of view for both

rahulanand16nov commented 2 years ago

Are we consistent with the RLP? I am assuming yes but wanted to check that the user experience is at least similar from a status point of view for both

Yes, as of now.

eguzki commented 2 years ago

is README.md doc up to date regarding auth?

rahulanand16nov commented 2 years ago

is README.md doc up to date regarding auth?

Docs update coming in next PR :)