search

Kuadrant / kuadrant-operator

The Operator to install and manage the lifecycle of the Kuadrant components deployments.
Apache License 2.0
37 stars 33 forks source link

Consistent labeling for Operator metric Services #846

Open jsmolar opened 2 months ago

jsmolar commented 2 months ago

Current labeling for Operator Metric Services

Proposed Change

To achieve consistency in the labeling of Operator metric services, I propose aligning the labels according to the pattern implemented by the authorino-operator, or by a new common pattern.

Two potential approaches:

  1. Change label value to reflect correct service kuadrant-operator-metrics - control-plane=kuadrant-operator authorino-operator-metrics - control-plane=authorino-operator limitador-operator-metrics - control-plane=limitador-operator dns-operator-metrics - control-plane=dns-operator

  2. Change both key and value kuadrant-operator-metrics - component=kuadrant-operator authorino-operator-metrics - component=authorino-operator limitador-operator-metrics - component=limitador-operator dns-operator-metrics - component=dns-operator

david-martin commented 3 weeks ago

When labels are changed, please also update the ServiceMonitors as needed to ensure they target the correct Services. See https://github.com/Kuadrant/kuadrant-operator/pull/953#discussion_r1814655693 for related discussion on this.