Closed eloycoto closed 3 years ago
on kuadrantctl install
command, certmanager is installed?
on kuadrantctl install command, certmanager is installed?
It should? I do not think so at all, cert-manager should be installed by default, no?
on kuadrantctl install command, certmanager is installed?
It should? I do not think so at all, cert-manager should be installed by default, no?
In k8s it is not installed by default.
The thing is:
I would take extra care here TBH, because this cluster-wide tools/dependencies are something that we need, but can make things complicated to operate in the near future, when other tools maybe install it.
TBH: I would move these kinds of dependencies to kuadrantctl install cluster-wide-deps
where maybe you can install prometheus/cert-manager/etc..
Regards
There is a point in what you say.
The install
command can check if the certmanager is installed and fail if not. It should be easy just checking CRDs.
certmanager would become a dependency of kuadrant (do we want that?) and add documentation links to install procedure. Surely, technically we do not need TLS on authorino, so adding a dependency seems too hard requirement.
Instead of another command, I would add Makefile target for dev purposes. I do not see a kusdrantctl specific command to install certmanager. This is out of scope, IMO.
Closing because https://github.com/Kuadrant/authorino/issues/128 will fix the issue. I will pin the version.
When using the latest authorino version, cert-manager is needed to deploy authorino, so:
Signed-off-by: Eloy Coto eloy.coto@acalustra.com