search

Kuadrant / kuadrantctl

Kuadrant configuration command line utility
Apache License 2.0
6 stars 12 forks source link

Add APICurio guide for modifying and visualising kuadrant extensions #57

Closed david-martin closed 4 months ago

david-martin commented 4 months ago

Closes https://github.com/Kuadrant/docs.kuadrant.io/issues/63

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.38%. Comparing base (888948e) to head (6b59c0b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #57 +/- ## ===================================== Coverage 0.38% 0.38% ===================================== Files 17 17 Lines 783 783 ===================================== Hits 3 3 Misses 780 780 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasonmadigan commented 4 months ago

taking shape, couple of comments added

jasonmadigan commented 4 months ago

@david-martin this LGTM. It may be worth an eye from someone from Apicurio as well, but this can be merged as a draft

david-martin commented 4 months ago

may be worth an eye from someone from Apicurio

@jasonmadigan Good suggestion. Do you mind if you add lgtm etc.. and I can get a deploy preview link on the docs repo to share with them for review before it actually gets published?

jasonmadigan commented 4 months ago

/lgtm /approve

david-martin commented 4 months ago

Merging manually. Auto merge not marking the GH review as good, but lgtm added