Kuadrant / limitador-operator

Apache License 2.0
6 stars 14 forks source link

Adding packages other than `controllers` to the code coverage report from the integration tests #129

Closed eguzki closed 7 months ago

eguzki commented 7 months ago

What

Adding packages other than controllers to the code coverage report from the integration tests

Code coverage has increased 18% the full code coverage :tada: up to 86%

Screenshot 2024-04-04 at 20-46-23 Code coverage done right

Makes sense. Integration tests also run code other than in the controllers package that was not covered with the unit tests

Additionally:

codecov-commenter commented 7 months ago

Codecov Report

Merging #129 (a08cce7) into main (e9207fb) will increase coverage by 17.09%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## =========================================== + Coverage 68.19% 85.29% +17.09% =========================================== Files 16 19 +3 Lines 1154 959 -195 =========================================== + Hits 787 818 +31 + Misses 325 92 -233 - Partials 42 49 +7 ``` | [Flag](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `79.24% <ø> (+6.67%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `67.22% <ø> (+0.92%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [api/v1alpha1 (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `100.00% <ø> (ø)` | | | [pkg/helpers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `83.87% <ø> (∅)` | | | [pkg/log (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `94.73% <ø> (+62.91%)` | :arrow_up: | | [pkg/reconcilers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `74.67% <ø> (+37.90%)` | :arrow_up: | | [pkg/limitador (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `98.74% <ø> (+10.61%)` | :arrow_up: | | [controllers (i)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `74.72% <ø> (+2.14%)` | :arrow_up: | | [pkg/upgrades](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `88.88% <ø> (+15.55%)` | :arrow_up: | [see 17 files with indirect coverage changes](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/129/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant)