Kuadrant / limitador-operator

Apache License 2.0
6 stars 14 forks source link

feat: run integration tests concurrently #134

Closed KevFan closed 5 months ago

KevFan commented 6 months ago

Locally the integration tests completes in ~1m40s (Pipeline can take longer overall ~ 4mins due to the workflow steps) (Previously takes ~11mins to complete when running sequentially)

image
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.71%. Comparing base (dab1824) to head (b57dbfa). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## =========================================== + Coverage 66.61% 84.71% +18.10% =========================================== Files 14 19 +5 Lines 659 988 +329 =========================================== + Hits 439 837 +398 + Misses 208 98 -110 - Partials 12 53 +41 ``` | [Flag](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `78.64% <ø> (?)` | | | [unit](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `66.41% <ø> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [api/v1alpha1 (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `100.00% <ø> (+9.52%)` | :arrow_up: | | [pkg/helpers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `83.87% <ø> (∅)` | | | [pkg/log (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `94.73% <ø> (+57.89%)` | :arrow_up: | | [pkg/reconcilers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `74.67% <ø> (+37.99%)` | :arrow_up: | | [pkg/limitador (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `98.10% <ø> (+10.20%)` | :arrow_up: | | [controllers (i)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `74.32% <ø> (∅)` | | | [pkg/upgrades](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `88.88% <ø> (+13.88%)` | :arrow_up: | [see 15 files with indirect coverage changes](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/134/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant)
eguzki commented 5 months ago

tests failing due to issue with limitador latest image. We are working on that.

KevFan commented 5 months ago

tests failing due to issue with limitador latest image. We are working on that.

@eguzki I've a potential fix at https://github.com/Kuadrant/limitador/pull/323#pullrequestreview-2055064028