Kuadrant / limitador-operator

Apache License 2.0
6 stars 14 forks source link

fix: remove obselete flags from redis options #135

Closed KevFan closed 5 months ago

KevFan commented 5 months ago

With https://github.com/Kuadrant/limitador/pull/317/files being merged, the following integration test has been failing due to the flags have been removed and no longer accepted by the latest version of Limitador

  [TIMEDOUT] Limitador controller Deploying limitador object with redis cached storage [It] with all the optional parameters, the command line is correct

Failing test in pipeline:

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.61%. Comparing base (0713794) to head (74488f8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== - Coverage 85.65% 79.61% -6.05% ========================================== Files 19 19 Lines 990 986 -4 ========================================== - Hits 848 785 -63 - Misses 93 139 +46 - Partials 49 62 +13 ``` | [Flag](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `79.61% <ø> (-0.59%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [api/v1alpha1 (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `90.47% <ø> (-9.53%)` | :arrow_down: | | [pkg/helpers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `83.87% <ø> (ø)` | | | [pkg/log (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `57.89% <ø> (-36.85%)` | :arrow_down: | | [pkg/reconcilers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `67.68% <ø> (-6.99%)` | :arrow_down: | | [pkg/limitador (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `91.71% <ø> (-7.03%)` | :arrow_down: | | [controllers (i)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `75.67% <ø> (-1.02%)` | :arrow_down: | | [pkg/upgrades](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `88.88% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [api/v1alpha1/limitador\_types.go](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135?src=pr&el=tree&filepath=api%2Fv1alpha1%2Flimitador_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#diff-YXBpL3YxYWxwaGExL2xpbWl0YWRvcl90eXBlcy5nbw==) | `90.47% <ø> (-9.53%)` | :arrow_down: | | [pkg/limitador/redis\_cache\_storage\_options.go](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135?src=pr&el=tree&filepath=pkg%2Flimitador%2Fredis_cache_storage_options.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#diff-cGtnL2xpbWl0YWRvci9yZWRpc19jYWNoZV9zdG9yYWdlX29wdGlvbnMuZ28=) | `88.23% <ø> (-11.77%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/135/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant)