search

Kuadrant / limitador-operator

Apache License 2.0
6 stars 14 forks source link

Inconsistent Tracing Configuration: Missing insecure Field in Limitador CR #141

Open jsmolar opened 5 months ago

jsmolar commented 5 months ago

When configuring tracing for the Authorino Custom Resource (CR), it requires the following configuration:

tracing:
  endpoint: rpc://tempo.tempo.svc.cluster.local:4317
  insecure: true

However, the Limitador CR does not include the insecure field in its tracing configuration. This inconsistency raises the question of whether the omission is intentional or an oversight.

For reference, the documentation on tracing configuration can be found here: Kuadrant Tracing Configuration.

Is this discrepancy intended, or should the Limitador CR also support the insecure field for tracing configuration?

adam-cattermole commented 5 months ago

This is currently by design. Limitador only supports insecure tracing at present, so to avoid the confusion of the user setting insecure: false with no outcome the field has been excluded until limitador supports secure tracing. I could potentially see an argument for the field to be present set to true with the operator always reconciling changes back to true for now but I think that would be a strange behaviour albeit consistent.