Kuadrant / limitador-operator

Apache License 2.0
6 stars 14 forks source link

Refactoring service name and metrics port to match authorino #150

Closed R-Lawton closed 4 months ago

R-Lawton commented 4 months ago

Updating metrics service name and removing patch for metrics port to make limitador operator more inline with authorino-operator. The conversation that sparked changes: https://github.com/Kuadrant/authorino-operator/pull/187

Verification:

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.40%. Comparing base (e3f28fc) to head (7b54231).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #150 +/- ## ========================================== - Coverage 85.31% 84.40% -0.91% ========================================== Files 19 19 Lines 994 994 ========================================== - Hits 848 839 -9 - Misses 95 100 +5 - Partials 51 55 +4 ``` | [Flag](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `78.37% <ø> (-1.31%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `66.51% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | Coverage Δ | | |---|---|---| | [api/v1alpha1 (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `100.00% <ø> (ø)` | | | [pkg/helpers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `83.87% <ø> (ø)` | | | [pkg/log (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `94.73% <ø> (ø)` | | | [pkg/reconcilers (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `74.67% <ø> (ø)` | | | [pkg/limitador (u)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `98.11% <ø> (ø)` | | | [controllers (i)](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `73.33% <ø> (-3.00%)` | :arrow_down: | | [pkg/upgrades](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant) | `88.88% <ø> (ø)` | | [see 2 files with indirect coverage changes](https://app.codecov.io/gh/Kuadrant/limitador-operator/pull/150/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Kuadrant)