search

Kuadrant / limitador

Rate limiter
Apache License 2.0
60 stars 21 forks source link

Simplify image builds by using QEMU to do multi-arch builds #350

Closed chirino closed 5 months ago

chirino commented 5 months ago

but since they are slow, only do the multi-arch builds for releases.

Also support passing cargo build args to the Docker image builder, allowing us to enable all features.

eguzki commented 5 months ago

If I understand this correctly, image is not being built on PR's. Is this something we want? Building an image is kind of a test as well that either passes or fails.

eguzki commented 5 months ago

If I understand this correctly, image is not being built on PR's. Is this something we want? Building an image is kind of a test as well that either passes or fails.

I realize that the image building on PR's was removed a while ago.

didierofrivia commented 5 months ago

I'd say that going back to quemu for the default building is not ideal as the default build job, I'd rather add it as a different dispatch workflow and/or only for releases

chirino commented 5 months ago

ok. closing PR, maybe revisit later.