search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
11 stars 23 forks source link

Renamed metric services #666

Closed Ygnas closed 11 months ago

Ygnas commented 11 months ago

What

This #648 PR introduced the policy controller metrics service and the quickstart-metrics script failed because it could not merge it with the previous service as they had the same name.

Verification

Both quickstart-setup and quickstart-metrics still work.

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maleck13 commented 11 months ago

/lgtm