search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
10 stars 23 forks source link

fix perms around issuers #667

Closed maleck13 closed 10 months ago

maleck13 commented 10 months ago

fix pkg/mod/k8s.io/client-go@v0.28.3/tools/cache/reflector.go:229: Failed to watch *v1.ClusterIssuer: unknown (get clusterissuers.cert-manager.io)

maleck13 commented 10 months ago

@mikenairn tested this locally and not seeing the error any more so looks good as the fix

maleck13 commented 10 months ago

added a fix for make deploy-policy-controller

mikenairn commented 10 months ago

I'm not totally sure why we haven't seen this error before (e2e tests), but it does appear that when using a cached client you also need the watch perm to get a resource, so ....

/lgtm /approve

mikenairn commented 10 months ago

/lgtm /approve

mikenairn commented 10 months ago

/lgtm /approve

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13,mikenairn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment